Add unit tests for JavaParserUtil name resolution - #8252
Merged
mernstcheckerframework merged 1 commit intoSep 22, 2026
Merged
mernstcheckerframework merged 1 commit into
mernstcheckerframework merged 1 commit into
Conversation
`JavaParserUtil.resolveTypeName` was exercised only indirectly, through the `ainfer-relevance` goal files, which cannot reach the cases that need types in more than one package. Run the resolver directly against fixture sources in `javaparserutil/superpkg` and `javaparserutil/subpkg`, covering inherited member types, package-private members that are not inherited across packages, and a member type that hides another one. Test-only change; no production code is modified. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: typetools/checker-framework/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mernstcheckerframework
approved these changes
Sep 22, 2026
mernstcheckerframework
enabled auto-merge (squash)
September 22, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #8246, so that its diff is smaller. This pull request changes no production code.
JavaParserUtil.resolveTypeNameis exercised only indirectly, through theainfer-relevancegoal files, which cannot reach the cases that need types in more than one package.JavaParserUtilTestruns the resolver directly against fixture sources injavaparserutil/superpkgandjavaparserutil/subpkg, covering inherited member types, package-private members that are not inherited across packages, and a member type that hides another one.🤖 Generated with Claude Code