Skip to content

Add unit tests for JavaParserUtil name resolution - #8252

Merged
mernstcheckerframework merged 1 commit into
typetools:masterfrom
mernst:javaparserutil-resolve-name-tests
Sep 22, 2026
Merged

mernstcheckerframework merged 1 commit into
typetools:masterfrom
mernst:javaparserutil-resolve-name-tests

Conversation

@mernst

@mernst mernst commented Sep 22, 2026

Copy link
Copy Markdown
Member

Split out of #8246, so that its diff is smaller. This pull request changes no production code.

JavaParserUtil.resolveTypeName is exercised only indirectly, through the ainfer-relevance goal files, which cannot reach the cases that need types in more than one package.

JavaParserUtilTest runs the resolver directly against fixture sources in javaparserutil/superpkg and javaparserutil/subpkg, covering inherited member types, package-private members that are not inherited across packages, and a member type that hides another one.

🤖 Generated with Claude Code

`JavaParserUtil.resolveTypeName` was exercised only indirectly, through the
`ainfer-relevance` goal files, which cannot reach the cases that need types
in more than one package.

Run the resolver directly against fixture sources in `javaparserutil/superpkg`
and `javaparserutil/subpkg`, covering inherited member types, package-private
members that are not inherited across packages, and a member type that hides
another one.

Test-only change; no production code is modified.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: typetools/checker-framework/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 294661f2-2ef3-406c-b938-419f91619fc2

📥 Commits

Reviewing files that changed from the base of the PR and between 6b16237 and ba0d536.

📒 Files selected for processing (7)
  • framework/src/test/java/org/checkerframework/framework/util/JavaParserUtilTest.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/subpkg/IntermediateSub.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/subpkg/Sub.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/superpkg/Base.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/superpkg/Intermediate.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/superpkg/SamePackageIntermediateSub.java
  • framework/src/test/java/org/checkerframework/framework/util/javaparserutil/superpkg/SamePackageSub.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mernstcheckerframework
mernstcheckerframework enabled auto-merge (squash) September 22, 2026 06:07
@mernstcheckerframework
mernstcheckerframework merged commit 18b87e6 into typetools:master Sep 22, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants