Small changes - #8276
Closed
mernst wants to merge 2 commits into
Closed
Small changes#8276mernst wants to merge 2 commits into
mernst wants to merge 2 commits into
Conversation
Four changes to `JavaParserUtil` that were made while working on typetools#8208, but that are independent of it: * Move the test for a local type declaration in `resolveTypeName` above the test for a type parameter, to group the two shadowing tests that return null, and say that a local class shadows a type parameter of the same name. Neither a `BlockStmt` nor a `SwitchEntry` is a `NodeWithTypeParameters`, so no iteration of the loop can take both branches and the order does not affect the result. * Say why `resolveTypeName` searches every member type that the enclosing type declares, whatever its access modifier is. * Document that `typeToTypeMirror` returns null for a use of a type variable, which it already did. * Replace the private `resolveTypeName` overload's vague "reads and writes a cache, for efficiency" by what that cache does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: typetools/checker-framework/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four changes to
JavaParserUtilthat were made while working on #8208, but that are independent of it:resolveTypeNameabove the test for a type parameter, to group the two shadowing tests that return null, and say that a local class shadows a type parameter of the same name. Neither aBlockStmtnor aSwitchEntryis aNodeWithTypeParameters, so no iteration of the loop can take both branches and the order does not affect the result.resolveTypeNamesearches every member type that the enclosing type declares, whatever its access modifier is.typeToTypeMirrorreturns null for a use of a type variable, which it already did.resolveTypeNameoverload's vague "reads and writes a cache, for efficiency" by what that cache does.