Expose EcoBytes - #70
Merged
Merged
Conversation
laurmaedje
reviewed
Sep 1, 2026
laurmaedje
left a comment
laurmaedje
left a comment
Member
There was a problem hiding this comment.
Thanks for the very high-quality PR! I made some minor adjustments and added those as separate commits. Feel free to review them before I merge (I'll probably squash into two commits: One for the file rename and then the rest.)
I also have some additional docs nits and shuffling-arounds for more consistency, but those also affect unrelated code, so I've committed them separately to a branch, which I would merge after your PR has landed.
Contributor
Author
|
I like all your changes here! Especially the doc cleanup, I made them too repetitive. |
Member
|
Published 0.3.1 with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thanks a ton for a great library!
My attempt to revive #23.
Tried splitting it into several commits for easier review.