Reword the github diagnostic summary - #84
Draft
saecki wants to merge 1 commit into
Draft
Conversation
Member
|
To me an error means the package won't work at all, and a warning means it will work but doesn't follow best practices. Warnings exist to encourage package authors to follow these practices, but if they want to submit a low quality package despite the warnings, I think they should be allowed to do so. If you feel like we should be more strict about warnings and force people to fix them unless they really are false positives, we can discuss it a bit more, I'm not strongly opposed to that. |
saecki
marked this pull request as draft
August 10, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the previous wording contributed to repeated discussions about warnings that should indeed be fixed.
Still open to tweak this new summary though :)