itemplate:0.1.0 - #5729
Conversation
|
I delibrately put all source files associated with this project, except for the iconfont files, in the |
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for this template :)
|
|
||
| ```typst | ||
| // document.typ | ||
| #import "@preview/itemplate: 0.1.0": * |
There was a problem hiding this comment.
There is an extra space before the version number here.
There was a problem hiding this comment.
The extra space has been deleted.
There was a problem hiding this comment.
Can you remove that file please? It is a compilation artifact and is not referenced anywhere.
There was a problem hiding this comment.
This file too doesn't really belong here, it is more useful for you or other maintainers, so it should only live in your own repository. Can you remove it too, please?
| html.link(rel: "stylesheet", href: "https://unpkg.com/@hexiongwu1995/itemplate/styles/style.css") | ||
| // html.link(rel: "stylesheet", href: "./assets/styles/style.css") |
There was a problem hiding this comment.
Regarding assets management, you should either:
- Use unpkg all the time and remove the local copies of the files
- Use bundle export to re-export them along the HTML document, and stop relying on unpkg. You can keep using for font files, load them from another third-party, or add a parameter that lets users provide the font files themselves.
There was a problem hiding this comment.
I choose to use the unpkg method. All css and js files has been removed.
…epository are removed. The import error from README.md has been corrected.
|
@elegaanz I have made some changes, please check this package again. |
I am submitting
This package restructures the default exported HTML file to provide a more complex structure for subsequent CSS styling and JS manipulation. CSS and JS resources are provided default from an npm package "@hexiongwu1995/itemplate" but can also be downloaded form this package's sub directory to ensure reliability and stability.
Unfortunatly, the iconfont files can only be accessed from the npm package mentioned above because typst does not support uploading to their repository.
I have read and followed the submission guidelines and, in particular, I
Explanation: the name contains the word "template" which explains itself as a html template. The prefix "i" makes the name very short, easy to remember and sounds unique.
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE