Skip to content

Enable PLC1901#4418

Merged
timothy-nunn merged 2 commits into
ukaea:mainfrom
je-cook:PLC1901
Jul 7, 2026
Merged

Enable PLC1901#4418
timothy-nunn merged 2 commits into
ukaea:mainfrom
je-cook:PLC1901

Conversation

@je-cook

@je-cook je-cook commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

enables PLC1901

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook je-cook requested a review from a team as a code owner July 7, 2026 12:59
@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (a3db864) to head (543681e).

Files with missing lines Patch % Lines
process/core/io/vary_run/config.py 0.00% 7 Missing ⚠️
process/core/io/in_dat/base.py 0.00% 2 Missing ⚠️
process/core/io/plot/summary.py 0.00% 2 Missing ⚠️
process/core/io/vary_run/tools.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4418      +/-   ##
==========================================
+ Coverage   48.84%   48.85%   +0.01%     
==========================================
  Files         151      151              
  Lines       29406    29390      -16     
==========================================
- Hits        14363    14359       -4     
+ Misses      15043    15031      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/core/io/in_dat/base.py Outdated
Comment thread process/core/io/in_dat/base.py Outdated
Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>

@timothy-nunn timothy-nunn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will just note that I have considered the slight logic change that has been introduced:

  • Before: the IN.DAT parameter parsing only discarded the last element if it was empty
  • After: the parser discards any element that is empty
    This change should actually make us more robust to IN.DAT's with atypical features.

@timothy-nunn timothy-nunn merged commit e9d8681 into ukaea:main Jul 7, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants