fix(variable:get): avoid TypeError when selecting a variable interactively

[pjcdawkins]

What

Fixes a fatal TypeError thrown by variable:get when a variable is chosen interactively (i.e. the command is run without a name argument).

Symptom

The command runs, prompts for a variable, and displays it correctly — then crashes while printing the trailing hint:

Fatal error: Uncaught TypeError: OsUtil::escapeShellArg(): Argument #1 ($argument) must be of type string, null given
  ... in src/Command/Variable/VariableGetCommand.php on line 134

Cause

The name argument is optional. In the interactive path it stays null, but it was still passed to OsUtil::escapeShellArg() (which requires a string) when rendering the "To update the variable" hint. The crash happens after the variable has already been displayed, so the command appears to succeed and then fatals.

Fix

Use the selected variable's own name ($variable->name), which is populated in every code path, instead of the raw argument.

Notes

• PHPStan level 9 (open PR chore(legacy): raise PHPStan to level 9 #100) detects this as escapeShellArg() expects string, mixed given but currently baselines it as noise. Once this merges, that baseline entry becomes obsolete and should be dropped on rebase.
• No regression test added: the crash is specific to the interactive-selection path, which neither the PHP mock-API command tests nor the Go integration-test harness (PR Add integration tests for 10 new CLI commands #33) can drive via stdin today.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes a crash in the legacy PHP CLI variable:get command when running interactively (no name argument provided). The command previously displayed the selected variable successfully, then fatally errored while rendering the “update” hint due to passing null into a strictly-typed shell-escaping helper.

Changes:

• Use the selected variable’s populated name ($variable->name) instead of the optional input argument ($name) when building the trailing variable:update hint.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.