feat: add DNS server to guest boot args - #1051
slash-init wants to merge 3 commits into
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
hey @cmainas , just following up on this PR since it's been a couple weeks. |
|
Hello @slash-init , please sign your commits. |
1cc92ea to
e585a8e
Compare
|
The commit is still unsigned. |
Signed-off-by: slash <amvermagaurav007@gmail.com>
e585a8e to
b97c928
Compare
|
@cmainas thanks for pointing that out |
cmainas
left a comment
There was a problem hiding this comment.
Thank you @slash-init for the updates. I have added some comments. Also, please do not forget to add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml
Signed-off-by: slash <amvermagaurav007@gmail.com>
Signed-off-by: slash <amvermagaurav007@gmail.com>
|
@cmainas thanks! |
Description
This adds DNS server handling for guests that support configuring DNS through boot/runtime arguments.
The DNS server is read from the OCI
/etc/resolv.confmount and passed throughNetDevParamsto the guest-specific network configuration.Currently this adds DNS handling for:
Tests have also been added for the new DNS handling.
Rumprun is left out for now based on the discussion in #1039, since it does not appear to support configuring DNS through boot arguments.
Related issues
How was this tested?
/etc/resolv.conf->NetDevParams.DNSServerpath still needs end-to-end verification.LLM usage
GPT 5.6 Luna was used to assist with implementation. All generated code was reviewed.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).