Skip to content

feat: add DNS server to guest boot args - #1051

Open
slash-init wants to merge 3 commits into
urunc-dev:mainfrom
slash-init:feat/1039-dns-server-boot-args
Open

slash-init wants to merge 3 commits into
urunc-dev:mainfrom
slash-init:feat/1039-dns-server-boot-args

Conversation

@slash-init

@slash-init slash-init commented Sep 16, 2026 •

Copy link
Copy Markdown

Description

This adds DNS server handling for guests that support configuring DNS through boot/runtime arguments.

The DNS server is read from the OCI /etc/resolv.conf mount and passed through NetDevParams to the guest-specific network configuration.

Currently this adds DNS handling for:

  • Mirage
  • Hermit
  • Mewz

Tests have also been added for the new DNS handling.

Rumprun is left out for now based on the discussion in #1039, since it does not appear to support configuring DNS through boot arguments.

Related issues

How was this tested?

  • Added unit tests for Mirage and Mewz DNS handling.
  • Ran the relevant Go tests locally.
  • The OCI /etc/resolv.conf -> NetDevParams.DNSServer path still needs end-to-end verification.

LLM usage

GPT 5.6 Luna was used to assist with implementation. All generated code was reviewed.

Checklist

@netlify

netlify Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for urunc ready!

Name Link
🔨 Latest commit 88ec7da
🔍 Latest deploy log https://app.netlify.com/projects/urunc/deploys/6abd0a9d889aae0008a5953b
😎 Deploy Preview https://deploy-preview-1051--urunc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@slash-init

Copy link
Copy Markdown
Author

hey @cmainas , just following up on this PR since it's been a couple weeks.
the current changes implement DNS boot-arg handling for Mirage, Hermit and Mewz, with tests for the new behavior. Rumprun is left out based on the discussion in the issue.
happy to address any feedback or changes needed.

@slash-init
slash-init marked this pull request as ready for review September 28, 2026 12:19
@cmainas

cmainas commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Hello @slash-init ,

please sign your commits.

@slash-init
slash-init force-pushed the feat/1039-dns-server-boot-args branch from 1cc92ea to e585a8e Compare September 28, 2026 14:08
@cmainas

cmainas commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

The commit is still unsigned.

Signed-off-by: slash <amvermagaurav007@gmail.com>
@slash-init
slash-init force-pushed the feat/1039-dns-server-boot-args branch from e585a8e to b97c928 Compare September 30, 2026 07:25
@slash-init

Copy link
Copy Markdown
Author

@cmainas thanks for pointing that out
i’ve added the DCO sign-off to the commit and force-pushed the updated commit.

@cmainas cmainas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @slash-init for the updates. I have added some comments. Also, please do not forget to add yourself in https://github.com/urunc-dev/urunc/blob/main/.github/contributors.yaml

Comment thread pkg/unikontainers/unikernels/mirage.go Outdated
Comment thread pkg/unikontainers/unikernels/mirage.go
Comment thread pkg/unikontainers/unikernels/hermit_rs_test.go Outdated
Signed-off-by: slash <amvermagaurav007@gmail.com>
Signed-off-by: slash <amvermagaurav007@gmail.com>
@slash-init

slash-init commented Sep 30, 2026 •

Copy link
Copy Markdown
Author

@cmainas thanks!
addressed the review feedback and added myself to the contributors list.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read and set the DNS server for every guest

2 participants