Skip to content

Remove Rascal search path contribution feature #2868

Description

@toinehartman

Describe the bug

On every operation on a Rascal search path, the complete search path is rebuilt in RascalSearchPath::collect:

public List<ISourceLocation> collect() {
List<ISourceLocation> paths = new LinkedList<ISourceLocation>();
for (IRascalSearchPathContributor c : contributors) {
c.contributePaths(paths);
}
return paths;
}

The path cannot be simply built once, because the search path can be amended after the evaluator has been initialized. However, in a typical scenario, the search path is set up before any operations on the search path. Hence, the result of collect() could be re-used and only invalidated on changes to the search path, to greatly reduce the number of collections being built.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions