Repository navigation
Conversation
|
sorry but i am not going to revert anything until we have a CI running for redox |
|
I think we don't need to revert this since we were not running test(impossible?) for Redox on the CI previously. |
|
I think we should add a check-only job at the very least: cargo check --all-targets --features feat_os_unix_redox --target x86_64-unknown-redoxWe can set |
|
Sounds good |
This comment was marked as outdated.
This comment was marked as outdated.
|
Do we really need to hurry supporting test on redox? Most logic are shared with other platforms. |
d2139df to
e8df3ba
Compare
Merging this PR will improve performance by 5.1%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | factor_thirteen_39_bit_primes |
9.5 s | 8.8 s | +7.76% |
| ⚡ | Simulation | factor_three_39_bit_primes |
567 ms | 544.1 ms | +4.2% |
| ⚡ | Simulation | factor_five_38_bit_primes |
1.6 s | 1.6 s | +3.4% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:GH14664 (2e3fcdd) with main (7654e67)
Footnotes
-
70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
5787bfb to
5489611
Compare
|
If we replaced |
546552d to
d71ebe6
Compare
|
Split the |
|
|
Is there any collaborator for |
|
Since their famous project (e.g. |
87b655d to
bcf484c
Compare
Closes #14914.
Reverts #14664.