Use underscore names for synthetic plan MCP tools - #164
Merged
Conversation
Rename Atryum's synthetic plan helpers away from dotted MCP tool names, update the related runtime guidance and tests, and add a regression test that fails if dotted synthetic tool names reappear in tools/list. Co-authored-by: Amp <amp@openai.com> Amp-Thread-ID: https://ampcode.com/threads/T-019faa2d-bcae-7439-9d2e-a6672f07f7ca Co-authored-by: Amp <amp@ampcode.com>
nibalizer
marked this pull request as draft
July 28, 2026 20:01
Keep the calculator integration target on a compatible MCP Python version line. mcp-server-calculator 0.1.1 still imports mcp.server.fastmcp, which was removed in MCP 2.x, causing the direct MCP smoke tests to fail with EOF after the helper venv resolved mcp 2.0.0. Co-authored-by: Amp <amp@openai.com> Amp-Thread-ID: https://ampcode.com/threads/T-019faa2d-bcae-7439-9d2e-a6672f07f7ca Co-authored-by: Amp <amp@ampcode.com>
nibalizer
marked this pull request as ready for review
July 28, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atryum_plan_submitandatryum_plan_gettools/listever returns dotted synthetic tool names againAlso includes a commit where I cleaned up messaging in some comments after discussing auth with amp.
Why
Anthropic/Claude rejects dotted tool names during tool registration, so the previous synthetic helper names (
atryum.plan.submit/atryum.plan.get) could break MCP tool exposure even though they were otherwise valid MCP identifiers.Testing
git diff --check -- README.md examples/codex-mcp/README.md internal/api/auth_test.go internal/api/handlers.go internal/api/handlers_test.go internal/invocation/local_evaluator.go internal/invocation/plan_service.go internal/invocation/plan_service_test.gogo test/gofmtare unavailable in this container (goandgofmtnot onPATH)