Skip to content

Offer ambiguous calls at choice portals the player picks with 1–9 - #44

Merged
valuecodes merged 3 commits into
mainfrom
feat/ambiguous-call-chooser
Oct 14, 2026
Merged

valuecodes merged 3 commits into
mainfrom
feat/ambiguous-call-chooser

Conversation

@valuecodes

Copy link
Copy Markdown
Owner

What

  • Part 3/5 of Post-MVP additions: an ambiguous call with 2–9 candidates is no longer folded into the room's closed marker. It gets a violet choice portal that names its candidates, and the player picks one with 1–9. There is still no guessed link: walking into the frame does nothing.
  • A pick pushes a call frame like a call portal does, so a return portal and Backspace come back to the choice portal. A candidate in another module has its area generated on the key press. If that area could not be generated, the prompt marks the candidate (closed) and picking it does nothing.
  • The grammar counts one wall slot per choice, collapses repeats of the same candidate set within a room, and lists candidates from other modules in external and in the world map's call links. validateGraph checks choices: placed by the cluster, to === from, and 2–9 distinct known candidates.
  • Calls with more than 9 candidates, and dynamic, external and unresolved calls, stay on the marker.

How to test

pnpm typecheck
pnpm lint
pnpm knip
pnpm test
pnpm build
pnpm --filter web dev   # open /?code=resolution, face the violet portal, press 2

Security review

No security-impacting changes.

🤖 Generated with Claude Code

valuecodes and others added 2 commits October 14, 2026 09:46
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 14, 2026 07:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T07:04:33.610233Z 76b7cc5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76b7cc56bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/world-app.tsx Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@valuecodes
valuecodes merged commit 0543b51 into main Oct 14, 2026
10 checks passed
@valuecodes
valuecodes deleted the feat/ambiguous-call-chooser branch October 14, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants