Repository navigation
Unload far-away areas past a budget and regenerate them in place - #47
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AreaStore.evictdrops a built area but keeps its reserved place;ensureregenerates it deterministically at the same offset, so rooms, portals and return points are unchanged.AreaWorld.unloadedlists them; zones,checkAreasand the maps treat them as built (outlines withdata-area-state="unloaded", counted inn/total).createUnloader(area-budget.ts) keeps at most 12 areas loaded, least recently visited first. Pins are bounded: entry, the player's area, navigation's unit, the top frame's ends and the portal ahead. Backspace and return portals generate the top caller's area first.How to test
pnpm typecheck
pnpm lint
pnpm knip
pnpm test
pnpm build
pnpm --filter web dev # open http://localhost:3000/?code=self&stats=1, walk through more than 12 module portals:
areasholds near 12, geo/tex level off, walking back regenerates an area in the same place (Tab map)Security review
No security-impacting changes.
🤖 Generated with Claude Code