Advance workspace dependency bounds - #336
Open
scotttrinh wants to merge 4 commits into
Open
scotttrinh wants to merge 4 commits into
scotttrinh wants to merge 4 commits into
Conversation
elprans
reviewed
Sep 1, 2026
| for item in requirement.specifier | ||
| ] | ||
| marker = f" ; {requirement.marker}" if requirement.marker else "" | ||
| updated = f"{requirement.name}{extras}{','.join(specifiers)}{marker}" |
Collaborator
There was a problem hiding this comment.
packaging normalizes the marker to double quotes, producing:
dependencies = ["core>=0.1,<0.3.0 ; python_version < "3.11""]
tomllib.loads() then raises:
TOMLDecodeError: Unclosed array
Collaborator
Author
There was a problem hiding this comment.
ooof, thanks for catching that. I'm going to add some (failing) e2e tests to replace a bunch of monkeypatched stub-based tests to catch real-world issues like this. Going to push it failing now, and follow-up with the simple fix.
Collaborator
Author
elprans
reviewed
Sep 1, 2026
Update existing exclusive upper bounds during release preparation when a planned sibling version reaches them. Leave unbounded dependencies alone and reject ambiguous constraints instead of guessing.
scotttrinh
force-pushed
the
fix/advance-workspace-upper-bounds
branch
from
September 2, 2026 15:43
115c970 to
ccbc0d2
Compare
h/t @elprans > packaging normalizes the marker to double quotes, producing: > > dependencies = ["core>=0.1,<0.3.0 ; python_version < "3.11""] > > tomllib.loads() then raises: > > TOMLDecodeError: Unclosed array
scotttrinh
force-pushed
the
fix/advance-workspace-upper-bounds
branch
from
September 2, 2026 15:48
c02dbca to
505e914
Compare
scotttrinh
marked this pull request as ready for review
September 2, 2026 17:33
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a workspace package release reaches a dependent's existing exclusive upper bound, release preparation now advances that bound to the next compatibility boundary in the same generated release PR. This keeps deliberate compatibility bounds such as
vercel-internal-core<0.2.0from producing an uninstallable release when internal core first moves to0.2.0.