Cross-room damage strats - #2967
Open
blkerby wants to merge 5 commits into
Open
Conversation
blkerby
force-pushed
the
leave-with-damage-rebase
branch
from
August 30, 2026 02:07
860711a to
7194024
Compare
blkerby
force-pushed
the
leave-with-damage-rebase
branch
from
August 30, 2026 02:20
7194024 to
575cd1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leaveWithGModeSetupwith a more general exit conditionleaveWithDamage.leaveWithKnockback,leaveWithDamageBoost, andleaveWithIFrames.comeInWithKnockback,comeInWithDamageBoost,comeInWithIFrames.I would recommend reviewing this commit-by-commit.
The G-mode setup migration is large but mostly mechanical so I put the mechanical part in its own commit. It couldn't be fully automated as a simple script because the new schema needed the enemy name to be populated, so this was done with LLM assistance. It is supported by a test which checks that the enemy/attack name is one that exists in the enemies list in the room. The cases which needed some special handling were ones where originally there were multiple possible enemies that could be used; these needed to either be split into separate strats (e.g. where the available enemy depends on game state, in Wrecked Ship with power on/off), or just pick the enemy with lowest damage and mention the other in a note.