fix: align backend protocol with frozen adapters#337
Merged
Conversation
Model backend names as read-only protocol properties so ty accepts the frozen Rust and Python adapter implementations.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns the BackendAdapter protocol with existing frozen Rust/Python adapter implementations by making the adapter name a read-only property and updating architecture docs to describe the backend adapter metadata contract. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 729 730 +1
=========================================
+ Hits 729 730 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BackendAdapter.nameas a read-only protocol propertylat.mdRoot cause
BackendAdapterdeclarednameas a writable string attribute. The concrete adapters are frozen dataclasses, so ty correctly rejected them as protocol implementations because theirnamefields cannot be written.Impact
The ty typecheck passes without weakening diagnostics or changing runtime behavior.
Validation
VIRTUAL_ENV="$PWD/.venv" uvx ty check json2xml testsuvx ruff check json2xml tests.venv/bin/pytest --cov=json2xml --cov-report=xml:coverage/reports/coverage.xml --cov-report=term -q tests(312 passed, 94 skipped, 100% coverage)cargo test --manifest-path rust/Cargo.toml(46 passed)lat checkSummary by Sourcery
Model backend adapter names as read-only protocol properties to match frozen adapter implementations and update architecture docs accordingly.
Bug Fixes:
Documentation: