Skip to content

ci: restore macOS Python 3.10 release wheels#341

Merged
vinitkumar merged 1 commit into
masterfrom
fix/rust-release-py310-wheels
Jul 15, 2026
Merged

ci: restore macOS Python 3.10 release wheels#341
vinitkumar merged 1 commit into
masterfrom
fix/rust-release-py310-wheels

Conversation

@vinitkumar

@vinitkumar vinitkumar commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • provision CPython 3.10 explicitly in macOS Rust wheel builds
  • keep maturin's existing multi-interpreter discovery for Python 3.10–3.14
  • document why the oldest supported interpreter must not depend on runner preinstalls

Release failure reproduced

The rust-v0.4.2 release correctly stopped before PyPI publication because the macOS artifacts contained cp311–cp314 wheels but no cp310 wheel. The macOS/Python 3.10 installation gate rejected the artifact set with No matching distribution found.

Validation

  • workflow YAML parses successfully
  • lat check
  • a manual non-publishing run will validate the produced cp310 macOS wheel before merge

@sourcery-ai

sourcery-ai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensures macOS release wheel builds explicitly install Python 3.10 so maturin can build cp310 wheels, and documents this requirement in the architecture docs.

Flow diagram for macOS Rust wheel build with explicit Python 3.10 provisioning

flowchart TD
    A[macOS Rust wheel job starts] --> B[actions/checkout]
    B --> C[actions/setup-python python-version 3.10]
    C --> D[actions/setup-python python-version PYTHON_VERSION]
    D --> E[maturin build finds interpreters 3.10-3.14]
    E --> F[Emit wheels including cp310 for macOS]
Loading

File-Level Changes

Change Details Files
Explicitly provision Python 3.10 in the macOS Rust wheel CI workflow so maturin can build cp310 wheels even when the runner image no longer preinstalls it.
  • Insert a setup-python step before the existing Python setup in the macOS Rust wheel job.
  • Configure that new step to install Python version 3.10 into the toolcache, making it discoverable by maturin’s --find-interpreter logic.
.github/workflows/build-rust-wheels.yml
Document the explicit Python 3.10 provisioning behavior and rationale in the architecture documentation.
  • Extend the architecture notes about Rust toolchain pinning to also mention explicit provisioning of Python 3.10 in macOS release builds.
  • Clarify that this is required to ensure wheels are built for the oldest supported interpreter even if runner images omit it.
lat.md/architecture.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (560f743) to head (b938ab3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          759       759           
=========================================
  Hits           759       759           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@vinitkumar
vinitkumar merged commit d6f1100 into master Jul 15, 2026
70 checks passed
@vinitkumar
vinitkumar deleted the fix/rust-release-py310-wheels branch July 15, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant