Stabilize new build in separate repository, and get CI/CD working#8
Open
CodeByDrescher wants to merge 44 commits into
Open
Stabilize new build in separate repository, and get CI/CD working#8CodeByDrescher wants to merge 44 commits into
CodeByDrescher wants to merge 44 commits into
Conversation
Collaborator
Author
+ version output improvement
7a32b05 to
8f5f107
Compare
Also: adding windows on arm (woa) support(?)
8f5f107 to
68bbf1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize the ODE solver against sanitizers, modernize the build, and ship a
Python distribution alongside the native CLI.
argparse,spdlog,libcurl); CMake minimum 3.13 → 3.16; consolidate platform detection onWIN32; new optionsOPTION_TARGET_PYTHON_BINDING,OPTION_TEST_WITH_LOCALHOST,OPTION_STATICALLY_LINK; warning cleanuppass and
sprintfremoval so the C++20 build compiles clean.VCellSolverInput+VCellSolverFactory; introduce abstractVCellSolverbase; replace the 273-line hand-rolled argv parser in
SundialsSolverStandalonewithargparse; expose a reusablesolve(input, output, tid)entry inSundialsSolverInterface(used byboth the CLI and the Python module).
SimulationMessagingintoMessageEventManager(worker thread + queue, with documented lockordering),
CurlProxyClasses(AbstractCurlProxy/NullCurlProxy/CurlProxy— replaces#ifdef USE_MESSAGINGforests with polymorphism),JobEventStatus(now aJobEvent::Statusnamespaced enum), andWorkerEvent. Fixes from TSAN/UBSAN/leak runs: data race,mutex-access-before-constructor-finished, undefined behavior, memory
leaks, int overflow in a test.
std::jthread→std::threadforcompiler portability. Net:
SimulationMessaging.cpp755 → 194 lines.pyvcell_odesolver): scikit-build-core + vendoredpybind11;src/main.cppexposesversion()andsolve(cvode_input_file_path, output_file_path, tid=-1).arm64, Python 3.10–3.13. Per-platform Conan profiles,
cibuildwheelPython wheels,
lipomacOS Universal build, GHCR manylinux images,moldlinker on Linux, sanitizer-enabled CMake.IDAWin/tests/smoke/smoke.pywith a top-leveltests/dir of GoogleTest C++ tests (smoke, hello, message-processing)plus a
test_basic.pythat exercises the wheel.Test plan
ctest -VVgreen locally (Linux, macOS); Windows via CISundialsSolverStandalone_x64runs the smoke.cvodeInputandmatches
*.ida.expected/*.cvode.expectedpip installof the built wheel exposespyvcell_odesolver.solve(...)and produces output matching the CLI-DOPTION_TARGET_MESSAGING=ONagainst a localhost broker(
-DOPTION_TEST_WITH_LOCALHOST=ON) — no TSAN/leak warningslipo -archs