Conversation
Update the pinned Vitess dependency so the tester no longer launches servers with removed glog flags. Adapt the affected APIs while preserving existing table output. Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this?
Updates the Vitess dependency used by the tester so it stops passing removed glog flags to current Vitess binaries.
How it works
Pins the test harness to the first upstream slog revision and adapts the small API changes that came with it. Existing
summary table output stays unchanged.
Testing
go test ./go/tester ./go/summarizemake prettyThe complete local suite still needs the Vitess binaries and etcd on
PATH.