New package: gotosocial-0.21.2#61009
Conversation
| version=0.21.2 | ||
| revision=1 | ||
| # https://docs.gotosocial.org/en/latest/getting_started/releases/#supported-platform | ||
| archs="~i686*" |
There was a problem hiding this comment.
was there a problem with i686? we can absolutely still support it even if upstream has partial support for it
There was a problem hiding this comment.
upstream support for i686 is a bit spotty, as we make use of an internal WebAssembly runtime for ffmpeg which gives us the following supported platforms chart: https://codeberg.org/superseriousbusiness/gotosocial#supported-platforms
another alternative is building with the nowasm build-tag which then skips using the WebAssembly runtime and uses the system ffmpeg binary. though we mark that as officially unsupported as we don't want to be liable for managing security releases on ffmpeg CVEs for our published images, checking CLI compatibility with user's distribution version etc.
another thing that could be considered, is we have build tags for disabling oidc integration, S3 storage support, metrics / tracing (which adds some overhead), so they could be added as build options in this package.
our list of supported build-tags can be found under scripts/build.sh in the main repo.
There was a problem hiding this comment.
i know as one of the GoToSocial developers, and also a Void user, i'd be ideal for maintaining a GoToSocial package, but unfortunately i am frequently lacking in free-time and i never had the energy to figure out how to manage distributed GoToSocial web asset templates while supporting user changes :p
There was a problem hiding this comment.
So we have two options:
- Skip i686 builds completely as they are in this PR
- Add nowasm for those and maybe some disclaimer. Also add ffmpeg as a dependency on those platforms.
I personally have no opinion on this matter so I would implement the decision of a more experience void contributor.
There was a problem hiding this comment.
Same for other build tags, don't know which ones make more sense for void.
|
the build failures here will be due to the updated Go imaging library in 1.26.x not producing byte-identical jpeg outputs compared to 1.25.x and previously, which our tests have hardcoded checksums for. it's probably just worth skipping those specific tests (those failing here) until we update our GoToSocial CI and tests to 1.26. |
Amlor
force-pushed
the
gotosocial
branch
3 times, most recently
from
ac357a6 to
9b81af1
Compare
4 participants
Testing the changes
New package
Local build testing