turnstile: move dinit service to usr/lib#61015
Open
dkwo wants to merge 1 commit into
Open
Conversation
Member
|
will this break things for users of turnstile + dinit? |
Contributor
Author
|
The turnstile + dinit (user) case is unaffected. This change is about dinit as system service. |
Member
|
if the dinit system service is chimera-specific, we probably shouldn't ship it at all |
Contributor
Author
|
I think leaving it as a reference is fine, but one should be able to safely edit it. Those targets are defined by dinit-chimera, while upstream dinit reference has only loginready. |
Contributor
Author
|
Anyhow, I am fine either way, just let me know what you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the package installs the service to
etc/dinit.d, there is no safe way to overwrite it, which we need to since it ships a dinit service taylored to Chimera linux. Put it intousr/libinstead, which is the same as Chimera does.cc @classabbyamp