llvm21: drop libcxx and libunwind options (now part of llvm22)#61029
llvm21: drop libcxx and libunwind options (now part of llvm22)#61029JkktBkkt wants to merge 1 commit into
Conversation
|
This doesn't need a rebuild. |
|
I think it would make sense to just disable the build options instead of removing all the code. |
8168424 to
347c33d
Compare
|
Builds like this, after enabling libunwind and libcxx as runtimes, otherwise runs into void-packages/srcpkgs/llvm21/template Line 637 in 529624a Converted to draft: am going to run builds on other archs (including cross) and a test build. |
347c33d to
080c7a6
Compare
|
Same testing done as in description, all went fine |
|
Isn't it enough to just change the default build options instead of unconditionally enabling the runtimes? |
|
Unfortunately not, that's what I tried first a few months ago (and again before finding commit by ahesford). #61029 (comment) has log snippet from running with just the |
|
I'd rather see the vestigial build options and supporting logic removed. Changing the default build options or removing them from the list of options obfuscates the fact that the template is unable to build should that option be enabled by an unsuspecting user. It's better to eliminate these dead bits of the template. |
|
I think its better to have a switch that can be turned off, there shouldn't be a guess what can be removed and what changes are require to the template or the resulting packages. It doesn't even have to be just build options defaults, you could remove it from There are some issues with how libcxx is build and installed multiple times, which should probably be fixed. Other than that, would probably even better if we just moved the runtimes out of the versioned llvm packages, but there might be issues with build cycles where llvm components may link the runtimes and the runtimes may need to be build with the latest llvm. |
Testing the changes
Local build testing
Closes #61005
I'm unsure if the revbump is necessary, there should be no functionality change from this, and this is addressing one of the roadblocks encountered in #59704
Based on bbdaa35 but I did not remove the lldb python integration.
[ci skip]