You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for taking the time to put this together, and for signing the CLA.
We unfortunately can't accept this PR. Both changes look like
they're working around SDK 3.6.1 specifically (rather than fixing something in
ClientSim itself):
UdonManager.UDON_EVENT_ONLANGUAGECHANGED and UdonManager.UDON_EVENT_ONVRCPLUSMASSGIFT are still present and public in
current SDK versions, so swapping them for string literals would be a
regression. We'd lose the compile-time safety of the constants on supported SDKs.
The Purchase() overload added to UdonProductStub doesn't match the
signature on the current IProduct interface, so it wouldn't compile against
a current SDK.
SDK 3.6.1 was released about two years ago
(https://creators.vrchat.com/releases/release-3-6-1), and ClientSim tracks the
current SDK rather than maintaining compatibility with older releases. Our
recommendation would be to update your project's SDK, which should resolve the
compile errors you're encountering.
If you update and still run into problems with ClientSim, please open a new
issue with the details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UdonProductStubto implement the currentIProduct.PurchaseoverloadUdonManagerconstants in SDK 3.6.1Validation
Tested in a clean world project using Unity 2022.3.22f1 and VRChat SDK 3.6.1.