Skip to content

fix: DynamicStatement.all ArrayList initialization #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrischmann merged 1 commit into from
Sep 11, 2026
Merged

fix: DynamicStatement.all ArrayList initialization #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion sqlite.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1951,7 +1951,7 @@ pub const DynamicStatement = struct {
pub fn all(self: *Self, comptime Type: type, allocator: mem.Allocator, options: QueryOptions, values: anytype) ![]Type {
var iter = try self.iteratorAlloc(Type, allocator, values);

var rows: std.ArrayList(Type) = .{};
var rows: std.ArrayList(Type) = .empty;
while (try iter.nextAlloc(allocator, options)) |row| {
try rows.append(allocator, row);
}
Expand Down Expand Up @@ -3558,6 +3558,24 @@ test "sqlite: oneDynamic" {
}
}

test "sqlite: dynamic statement all" {
var arena = std.heap.ArenaAllocator.init(testing.allocator);
defer arena.deinit();
const allocator = arena.allocator();

var db = try getTestDb();
defer db.deinit();
try addTestData(&db);

var stmt = try db.prepareDynamic("SELECT id FROM user WHERE age = ?");
defer stmt.deinit();

const rows = try stmt.all(usize, allocator, .{}, .{ .age = 33 });
defer allocator.free(rows);
try testing.expectEqual(@as(usize, 1), rows.len);
try testing.expectEqual(@as(usize, 20), rows[0]);
}

test "sqlite: one with all named parameters" {
var db = try getTestDb();
defer db.deinit();
Expand Down