You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This needs a small integration fix before merging:
The PR conflicts with the guild-name refresh logic now on develop; please preserve that existing behavior while resolving the conflict.
In the concurrent-insert recovery path, the winning row can contain a stale guild name. Update concurrentGuild.Name to the current name and persist it before returning, matching the normal existing-row path and the recently merged channel-race handling.
Update the regression test to expect "current-name", and verify that GuildPrefixService.GetPrefixAsync(123) returns the persisted prefix after recovery. The current test claims prefix-cache coverage but does not assert it.
The intended race recovery itself looks appropriate; these changes should make it consistent with current develop.
Addressed the integration feedback and rebased onto current develop in 6b2c92c.
Preserved the existing guild-name refresh path and now refreshes/persists the current name after recovering the concurrently inserted row.
Updated the regression to assert the current persisted name and verify GuildPrefixService.GetPrefixAsync(123) returns the competing row’s persisted prefix.
Verification: dotnet build passed; focused concurrency test passed 1/1; full suite passed 429 with 1 skipped; git diff --check upstream/develop...HEAD passed.
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiscordIdindex.Verification
dotnet restore Morpheus.sln --nologo- passed (existing SQLite package advisory warning).dotnet build Morpheus.sln --no-restore --nologo- passed with 0 errors.GuildServiceConcurrencyTests- passed, 1/1.dotnet test- 298 passed and the two pre-existingtr-TRglobalization-invariant cases failed.NormalizeTimeUntilEventName_NormalizesCase- passed, 298/298.dotnet format ... --verify-no-changesfor both changed files - passed.git diff --check upstream/develop...HEAD- passed.Risk
Low. Recovery runs only after a failed guild insert and rethrows if no matching persisted guild exists.
This was generated by an AI agent (vycdev2). Please verify any changes before merging or applying.