feat(config): add macOS vibrancy state setting - #3457
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughAdds the Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.5)frontend/types/gotypes.d.tsFile contains syntax errors that prevent linting: Line 1880: Expected a property, or a signature but instead found '#'.; Line 1880: Expected an expression, or an assignment but instead found ':'.; Line 1880: Expected an expression but instead found ']'.; Line 2193: Expected a statement but instead found '}'. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
window:visualeffectstatesetting withfollowWindow,active, andinactivevaluesBaseWindowwhen macOS vibrancy is enabledMotivation
Electron defaults
visualEffectStatetofollowWindow, which changes the vibrancy backdrop to its inactive appearance whenever the Wave window loses focus. For translucent window configurations, this can make the blur appear to disappear when switching to another app.This setting lets users opt into
activeso the native vibrancy backdrop remains visually consistent across focus changes. Existing behavior is unchanged when the setting is omitted or invalid: Wave usesfollowWindow.{ "window:blur": true, "window:visualeffectstate": "active" }The setting is macOS-only and is ignored on Windows and Linux. Windows keeps its existing acrylic material behavior; no cross-platform defaults change.
Validation
npm test -- --run— 14 test files, 46 tests passednpm exec eslint -- emain/emain-window.tsgo test ./pkg/wconfiggit diff --checkactivepreserves native vibrancy after moving focus to another applicationScope
This PR intentionally does not add new vibrancy materials or alter fullscreen behavior. It exposes only Electron's existing visual-effect activity state as a focused, opt-in configuration option.