Skip to content

Ci/macos personal build - #3458

Closed
zelenskymike wants to merge 2 commits into
wavetermdev:mainfrom
zelenskymike:ci/macos-personal-build
Closed

Ci/macos personal build#3458
zelenskymike wants to merge 2 commits into
wavetermdev:mainfrom
zelenskymike:ci/macos-personal-build

Conversation

@zelenskymike

Copy link
Copy Markdown

add 2nd action for personal macos build

@zelenskymike
zelenskymike deleted the ci/macos-personal-build branch July 30, 2026 14:06
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ba249c5-49e1-40ed-a844-1a75aad4aead

📥 Commits

Reviewing files that changed from the base of the PR and between a4447c1 and f2e9f9f.

📒 Files selected for processing (7)
  • .github/workflows/build-helper.yml
  • docs/docs/config.mdx
  • emain/emain-window.ts
  • frontend/types/gotypes.d.ts
  • pkg/wconfig/metaconsts.go
  • pkg/wconfig/settingsconfig.go
  • schema/settings.json

Walkthrough

The helper workflow is now a manually triggered, macOS-only packaging pipeline that builds with Task and uploads DMG and ZIP artifacts. A new window:visualeffectstate configuration setting is defined across Go, frontend, and JSON schemas, documented, and applied to macOS blurred windows with followWindow, active, and inactive handling.

Estimated code review effort: 3 (Moderate) | ~20 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Biome (2.5.5)
frontend/types/gotypes.d.ts

File contains syntax errors that prevent linting: Line 1880: Expected a property, or a signature but instead found '#'.; Line 1880: Expected an expression, or an assignment but instead found ':'.; Line 1880: Expected an expression but instead found ']'.; Line 2193: Expected a statement but instead found '}'.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant