Add option to embed JS in HTML report - #441
Merged
Merged
Conversation
…avascript should be included (useful in restricted-access scenarios)
sequencing_speed_over_time accessed settings.include_js while settings is a dict everywhere else, crashing every run that makes time plots. Also place the embedded plotly.js inside <body> rather than between </head> and <body>, and write individual plot html files with the javascript included, since the shared html deliberately carries none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M1T5vKqLLmxjb93BEZ9aSn
Owner
|
Hi Devon! Good idea, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I need to generate fully self-contained reports, such as when the people looking at them are behind firewalls that block external connections. In such cases the default mechanism of sourcing plotly javascript from a CDN doesn't work and it instead needs to be embedded in the HTML report. This PR add an option that will implement that, while keeping the current mechanism of using a CDN instead as the default.