Clarify --fixed-crop help text - #81
Conversation
The README options block is a paste of `chopper --help`, so correcting it there alone leaves `--help` wrong and the fix gets reverted on the next regeneration. Apply the same correction to the doc comments the help text is generated from, and note on --headcrop/--tailcrop that neither is required on its own. While there, --cutoff is also required by split-by-low-quality (main.rs :292), which its doc comment did not mention, and regenerate the README block so it matches the binary exactly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXEe5HBFCS7israxADWkU4
|
Thanks @JMencius — good catch, and thanks for digging up the validation code and a reproducer along with it. You were exactly right: only one of The README options block is a paste of Merging now, and it will go out in the next release. |
|
Yeah also the source code, good fix.
…---Original---
From: "Wouter De ***@***.***>
Date: Mon, Sep 14, 2026 02:13 AM
To: ***@***.***>;
Cc: "Jun ***@***.******@***.***>;
Subject: Re: [wdecoster/chopper] Clarify --fixed-crop help text (PR #81)
Merged #81 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I noticed a small documentation error in
README.mdwhile using chopper v0.14.0.When using
--trim-approach fixed-crop, only one of--headcropor--tailcropneeds to be greater than 0; they are not both required.This matches the validation logic in
src/main.rs(lines 248–253):A minimal test using only
--headcropalso confirms this behavior: