Enhance visibility and retry functionality for timed-out plan reviews - #2715
Merged
Conversation
Show a timeout state on plan review cards instead of removing them, with a Retry button that resubmits the original request. Four issues in that flow, found in review: The Retry button was disabled by the second expire pass. A journal replay or a panel reopen runs expirePlanReviewCards again, and its disable sweep matched every button in the card, including the one the first pass had just added. The sweep now skips the timeout footer, and a Retry button restored from persisted HTML is re-enabled when rebound. Restoring a timeout skipped the tab-wide sweep, so a card left by a run that died without a plan_resolved stayed interactive and could post a decision the background has no pending plan for. The sweep now runs in both branches; the card that just expired is skipped by invalidatePlanReviewCards' own guard. Blanking the assistant text dropped the turn from exported history, since extractChatHistoryMessages filters out messages with no text. A hidden marker keeps the record without showing the string twice. The expired-card guard in invalidatePlanReviewCards also skipped setPlanReviewAwaiting, which is not about removal. Moved above it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The marker only went in when .message-text already held the terminal cancellation string, which is the restore path. On a live timeout _waitForPlanReview emits plan_resolved before its caller returns that string, so the text is still empty when the card expires and the predicate is false. run_complete and the direct-response path then both suppress the string because the card is expired, so the text stays empty and extractChatHistoryMessages filters the turn out. Real timeouts still vanished from history. Insert the marker whenever a card expires. Text already streamed before the plan card is kept; only the terminal string is replaced. Reported by codex on PR #243. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Timed-out plan reviews stay visible and retryable
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.