fix: hide empty assistant placeholders - #2716
Merged
Merged
Conversation
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Hides empty assistant message shells until text, tool output, or interactive content renders.
Changes:
- Adds assistant-content visibility detection and mutation syncing.
- Hides awaiting assistant messages with CSS.
- Adds Chrome/Firefox parity assertions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/chrome/src/ui/sidepanel.js |
Manages placeholder visibility. |
src/chrome/styles/sidepanel.css |
Hides empty placeholders. |
src/firefox/src/ui/sidepanel.js |
Mirrors Chrome behavior. |
src/firefox/styles/sidepanel.css |
Mirrors Chrome styling. |
test/run.js |
Verifies mirrored visibility wiring. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2273
to
+2275
| if (contentEl.textContent.trim()) return true; | ||
| return !!contentEl.querySelector( | ||
| 'img, svg, canvas, video, audio, iframe, input, textarea, select, button, hr, progress', |
Comment on lines
+1685
to
+1687
| if (contentEl.textContent.trim()) return true; | ||
| return !!contentEl.querySelector( | ||
| 'img, svg, canvas, video, audio, iframe, input, textarea, select, button, hr, progress', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.