chore: upgrade recast, vitest, @vitest/coverage-v8 - #113
Merged
Merged
Conversation
- recast ^0.23.11 -> ^0.24.0 (cddl2java, cddl2ts) - vitest ^4.1.0 -> ^5.0.1, @vitest/coverage-v8 matching (root) release-it stays at 19.2.4 (already the highest version compatible with release-it-pnpm@4.6.6's peer range of ^17-19; 21.1.0 would break the release pipeline this repo's automation depends on - not touched here). recast 0.24.0 fixed a real parenthesization bug: a group-choice-in-array type like `[ (int // tstr) ]` was rendering as `Int | string[]`, which TypeScript parses as `Int | (string[])` - not what the CDDL means at all. Now correctly emits `(Int | string)[]`. Updated the one snapshot this affects; verified the fix against the actual CDDL source (examples/commons/group_choice.cddl) rather than just accepting the diff. Full checks:all passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Checked every direct dependency across the whole workspace (not just vitest) for its own engines.node, since the vitest-only fix could easily have missed something stricter: vitest@5.0.1 ^22.12.0 || ^24.0.0 || >=26.0.0 @release-it/conventional-changelog@12.0.2 ^22.22.2 || ^24.15.0 || >=26.0.0 npm-run-all2@9.0.3 ^22.22.2 || ^24.15.0 || >=26.0.0 conventional-changelog-conventionalcommits@10.4.0 >=22 release-it@19.2.4 ^20.12.0 || >=22.0.0 rimraf@6.1.3 20 || >=22 typescript@7.0.2 >=16.20.0 @release-it/conventional-changelog and npm-run-all2 both need newer patches than vitest does. Our engines.node was ">=22.0.0", then briefly just matched vitest's range - neither was the real combined floor. ^22.22.2 || ^24.15.0 || >=26.0.0 is the actual intersection: the strictest 22.x/24.x requirement across every direct dependency. Verified against the npm registry directly for each package, not just the local install. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-it stays at 19.2.4 (already the highest version compatible with release-it-pnpm@4.6.6's peer range of ^17-19; 21.1.0 would break the release pipeline this repo's automation depends on - not touched here).
recast 0.24.0 fixed a real parenthesization bug: a group-choice-in-array type like
[ (int // tstr) ]was rendering asInt | string[], which TypeScript parses asInt | (string[])- not what the CDDL means at all. Now correctly emits(Int | string)[]. Updated the one snapshot this affects; verified the fix against the actual CDDL source (examples/commons/group_choice.cddl) rather than just accepting the diff.Full checks:all passes.