Skip to content

fix(cddl2ts): add missing files field to package.json - #117

Merged
dprevost-LMI merged 1 commit into
webdriverio:mainfrom
dprevost-LMI:fix/cddl2ts-missing-files-field
Sep 23, 2026
Merged

dprevost-LMI merged 1 commit into
webdriverio:mainfrom
dprevost-LMI:fix/cddl2ts-missing-files-field

Conversation

@dprevost-LMI

Copy link
Copy Markdown
Collaborator

cddl2ts was the only workspace package without a "files" allowlist, so npm/pnpm fell back to gitignore-based inclusion for publishing - and the root .gitignore excludes build/. Every sibling package (cddl, cddl2java, cddl2py, cddl2swift, cddl2kotlin) already has "files": ["build", "bin"]; cddl2ts never did, in its entire release history.

This is the actual cause of cddl2ts@0.11.0 and 0.12.0 publishing without their build/ output - unrelated to the run-p/run-s race fix in #116, which was a real but separate issue. Verified in a clean worktree: with build/ compiled but no files field, pnpm pack --dry-run excluded build/ entirely; adding the field fixes it.

cddl2ts was the only workspace package without a "files" allowlist, so
npm/pnpm fell back to gitignore-based inclusion for publishing - and the
root .gitignore excludes build/. Every sibling package (cddl, cddl2java,
cddl2py, cddl2swift, cddl2kotlin) already has "files": ["build", "bin"];
cddl2ts never did, in its entire release history.

This is the actual cause of cddl2ts@0.11.0 and 0.12.0 publishing without
their build/ output - unrelated to the run-p/run-s race fix in webdriverio#116,
which was a real but separate issue. Verified in a clean worktree: with
build/ compiled but no files field, `pnpm pack --dry-run` excluded
build/ entirely; adding the field fixes it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the required compiled output and CLI files included in the published package.

Summary

Adds an npm publish allowlist to cddl2ts so compiled output and the CLI are included in published packages.

  • Publishes the build directory containing the package export.
  • Publishes the bin directory containing the CLI launcher.
  • Aligns cddl2ts with sibling package publishing conventions.

Reviews (1) · Last reviewed commit: "fix(cddl2ts): add missing files field to..."

@dprevost-LMI
dprevost-LMI merged commit 3ba551b into webdriverio:main Sep 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant