feat(logger): add configurable structured log pipelines - #5124
Draft
chrisadubois wants to merge 3 commits into
Draft
feat(logger): add configurable structured log pipelines#5124chrisadubois wants to merge 3 commits into
chrisadubois wants to merge 3 commits into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES # N/A - proof of concept for configurable SDK log pipelines
This pull request addresses
The Web Client needs to route SDK logs through its own OpenTelemetry runtime without making OpenTelemetry a dependency or default behavior of
webex-js-sdk. The SDK should own the stable record contract, formatting boundary, and configurable transport fanout while preserving its existing console and buffered upload behavior by default.by making the following changes
logRecordSchemav1 contract, shared attribute keys, controlled initiator and trigger taxonomies, and a 128-attribute limit.joinMeeting_<uuid>.logger.formatter(record)andlogger.transports[].write(record)contracts.transportspreserves the existing SDK console and buffer defaults[transport]sends admitted records only to that transport[]intentionally discards admitted recordsformatLogs()and incrementalsubmitLogsserialization when custom transports are omitted.Change Type
The following scenarios were tested
yarn workspace @webex/plugin-logger test:unit- 79 tests passed.yarn workspace @webex/internal-plugin-support test:unit- 43 tests passed on the earlier transport increment, covering legacy log submission compatibility.yarn workspace @webex/plugin-logger build- package built successfully for localSDK_DIRintegration.yarn workspace @webex/plugin-logger test:style- no errors; 8 existing JSDoc warnings.logToBuffer, legacy full/diff serialization, structured schema fields, taxonomy validation, attribute limits, readable event/operation IDs, strict native trace/span ID validation, and credential redaction.webex-web-clientthroughSDK_DIR.POC boundaries and production follow-ups
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that