Skip to content

Minimize jobs on non-release PRs - #367

Open
Saizan wants to merge 8 commits into
masterfrom
wip/andrea/319
Open

Minimize jobs on non-release PRs#367
Saizan wants to merge 8 commits into
masterfrom
wip/andrea/319

Conversation

@Saizan

@Saizan Saizan commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Managed to include the release runners only on release workflow.

Also unrelated cleanups:

  • cleaned up testing w/ haskell-debugger-view
  • made it so the tag only triggers a dry-run and need a workflow call for actual release.

Continues from #353

@Saizan
Saizan force-pushed the wip/andrea/319 branch 2 times, most recently from 1d2daf2 to dc5aec8 Compare September 7, 2026 14:38
Replaced with a release check that we are building against a sdist that agrees
with hackage.
@Saizan
Saizan force-pushed the wip/andrea/319 branch 2 times, most recently from 58130f9 to d0bc605 Compare September 8, 2026 15:31
@Saizan
Saizan marked this pull request as ready for review September 8, 2026 15:31
@Saizan

Saizan commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator Author

We don't yet check that compile-time ghc matches runtime ghc, as we only release for 9.14.1 for now.

@Saizan
Saizan requested a review from alt-romes September 8, 2026 17:27
@alt-romes

Copy link
Copy Markdown
Collaborator

We don't yet check that compile-time ghc matches runtime ghc, as we only release for 9.14.1 for now

I think we do, see

-- | Fetch the runtime GHC version, according to hie-bios, and check it is the
-- same as the compile time GHC version
hieBiosRuntimeGhcVersion :: HIE.Cradle Void
                         -> ExceptT String IO Version
hieBiosRuntimeGhcVersion cradle = do

@Saizan Saizan changed the title (Cont.) Release via ghcup Minimize jobs on non-release PRs Sep 8, 2026
@Saizan
Saizan force-pushed the wip/andrea/319 branch 2 times, most recently from 027a3e2 to fe12ffe Compare September 10, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants