Skip to content

Windows: pane/window close ("exit" & the X button) hangs — plus two packaging gaps (no app icon, console subsystem) #18

Description

@ailogic

Running the released v1.36.3 Windows MSI on Windows 11 — really enjoying the agent-team workflow. Hit one real bug and two small Windows packaging gaps (with suggested fixes) while setting it up.

1. Bug — closing a pane / exit / the window X hangs

Typing exit in a pane, or clicking the window's close (X), hangs the window ("Not responding"). It only recovers if I click to another window and back — then the X works. Classic focus/repaint stall on teardown.

Repro: open Sinclair → a pane → type exit (or click the X).

Caveat: I'd applied a local editbin /SUBSYSTEM:WINDOWS workaround (see #3) before noticing this, so I can't 100% rule it out as a contributor — but the "needs a focus-cycle to recover" symptom points to a windowing issue rather than the subsystem flip. Happy to test a build. Is this known on Windows?

2. No app icon on Windows (generic icon)

Start-menu/taskbar/exe show the generic Windows icon. Root cause: scripts/icon.sh is macOS-only (swift/sips/iconutil) → produces only icon.png/.icns, no .ico; crates/app/build.rs embeds no Windows resource; and packaging/windows/sinclair.wxs has no icon reference.

Fix: add assets/icon.ico, embed it in build.rs on Windows (e.g. via embed-resource), and reference it for the shortcut in sinclair.wxs.

3. Console window on launch (console subsystem)

Launching pops a console window alongside the GUI (hosted by Windows Terminal). Root cause: crates/app/src/main.rs has no #![cfg_attr(windows, windows_subsystem = "windows")], so the exe is a console-subsystem app and Windows attaches a console.

Fix (careful version): add the attribute, but because main.rs dispatches CLI subcommands (mcp, notify, agent-status, agent-hooks, export, ipc, _vm) that print to the terminal, also call AttachConsole(ATTACH_PARENT_PROCESS) when launched with args — otherwise those subcommands lose their output. (Note the two binaries sinclair/sinclairdev; the dev one may want to keep its console.) I worked around it locally with editbin /SUBSYSTEM:WINDOWS, which removes the console but may relate to #1.


Happy to open a PR for #2/#3 if useful — mainly wanted to flag #1. Thanks for Sinclair.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions