feat: add workflow run settings amendment route for app parity - #265
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Item A + Item B of the workflow-parity backend requirements (
zcode-acp-app/.zcode/docs/workflow-parity-backend-requirements.md).Item A — amend-workflow-run-settings REST route
POST /settings/workflow-runs/{runId}/settings?sessionId=(handleramendRunSettingsin src/settings/workflow.ts, route in src/remote/settings-endpoint.ts) sends the v4amendWorkflowRunSettingscommand via the samesendCommandpath as resume;workIdfilled from the path segment.null= revert to default, value = set (extracted by key presence, not through str()/num()).unchangedwith zero backend RPC; rejection tokens mapped per §2.2 (not_found 404 / not_configurable+unchanged+missing_boundaries 409 / model_unavailable+script_missing+compile_failed 422 / start_failed 502); capability absence keeps the generic mapping → 501, same as resumeWorkflowRun./settings/*proxy covers the prefix; the route sits under the existingworkflowRoutescapability gate.Item B — pinned passthrough tests
v4/conversation/workflowRuns→GET /settings/workflow-runsuntouched.GET /settings/workflows/runs.supersededByinvariant: never served withoutstopReason: "superseded"on both surfaces.Deliberately out of scope (spec §2.3/§5): no startSavedWorkflow changes, no client work; the §3.1/§3.2 upstream schema extensions are separate (command already exists upstream — verified against ZCode 3.14.3).
Tests: 1801 passed (13 new), typecheck/lint/build green. feat → 0.49.0 minor.