Skip to content

feat: meeting schedule design fixes [WPB-25048]#5003

Open
saleniuk wants to merge 3 commits into
developfrom
feat/meeting-schedule-design-fixes
Open

feat: meeting schedule design fixes [WPB-25048]#5003
saleniuk wants to merge 3 commits into
developfrom
feat/meeting-schedule-design-fixes

Conversation

@saleniuk

@saleniuk saleniuk commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-25048


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

During the design review, three issues were identified:

  • "Annually" option should be removed
  • "Biweekly" should be named “Every 2 weeks” (biweekly is an ambiguous term)
  • Changing the start time should also move the end time to the same day to reduce errors being shown

Solutions

  • "Annually" option hidden from the "schedule a meeting" option chooser
  • "Biweekly" label changed to "Every 2 weeks"
  • Date changing logic changed in a way that when the start time is changed, then end time is changed accordingly as well, keeping the same duration of the meeting, so it works the same as on Google Calendar

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open dev build, go to meetings, click "new" and "schedule" and play around with the form

Attachments (Optional)

Screen_recording_20260625_190721.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.36%. Comparing base (ac64db8) to head (54627de).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5003      +/-   ##
===========================================
+ Coverage    49.04%   49.36%   +0.32%     
===========================================
  Files          647      650       +3     
  Lines        23384    23456      +72     
  Branches      3596     3604       +8     
===========================================
+ Hits         11468    11579     +111     
+ Misses       10845    10803      -42     
- Partials      1071     1074       +3     
Files with missing lines Coverage Δ
.../feature/meetings/ui/create/NewMeetingViewModel.kt 85.26% <100.00%> (+12.34%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac64db8...54627de. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant