Skip to content

fix: TabController - clear stuck press feedback when a tap is cancelled on iOS #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mika-bejerano merged 1 commit into from
Sep 6, 2026
Merged

fix: TabController - clear stuck press feedback when a tap is cancelled on iOS #4042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/react-native-ui-lib/src/components/tabController/TabBarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,13 @@ export default function TabBarItem({
})
.onTouchesDown(() => {
isPressed.value = true;
})
// NOTE: On iOS a cancelled tap (i.e. when the enclosing ScrollView claims the touch) transitions the
// recognizer straight from POSSIBLE to CANCELLED, which emits no state change event, so onFinalize
// is never called and the press feedback stays on the item.
// Releasing it from the touch stream as well makes sure it is always cleared.
.onTouchesCancelled(() => {
isPressed.value = false;
});

return (
Expand Down
Loading