Skip to content

rename CW LED descriptions to more commonly used CCT#5612

Merged
DedeHai merged 6 commits into
wled:mainfrom
DedeHai:rename_CW_to_CCT
Jun 18, 2026
Merged

rename CW LED descriptions to more commonly used CCT#5612
DedeHai merged 6 commits into
wled:mainfrom
DedeHai:rename_CW_to_CCT

Conversation

@DedeHai

@DedeHai DedeHai commented May 13, 2026

Copy link
Copy Markdown
Collaborator

this is a suggestion to rename "CW" into "CCT"

@intermittech what do you think? Open for discussion

Summary by CodeRabbit

  • Documentation
    • Updated LED type display names returned by the LED types JSON API to more accurately reflect supported color-channel layouts, with clearer RGBCCT/RGBW wording for relevant bus types.
    • Revised inline channel labels and descriptive text for several supported LED bus formats so the displayed names align consistently with actual capabilities.

@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1f66c37e-a948-4229-a92d-30456963ea83

📥 Commits

Reviewing files that changed from the base of the PR and between 0422ffb and 6edbb53.

📒 Files selected for processing (1)
  • wled00/bus_manager.cpp
✅ Files skipped from review due to trivial changes (1)
  • wled00/bus_manager.cpp

Walkthrough

LED type display names and inline bus-method comments were updated to use CCT-style channel naming (e.g., "RGBCCT", "GRBCCT") and several RGB/RGBW descriptor texts were reformatted across two files.

Changes

LED Type Naming Standardization

Layer / File(s) Summary
LED Type Name API Update
wled00/bus_manager.cpp
BusDigital::getLEDTypes() and BusPwm::getLEDTypes() updated human-readable name strings for multiple LED types, reformatting RGB/RGBW descriptors and renaming CCT-capable variants to use "RGBCCT …"; TYPE_ANALOG_5CH renamed to "PWM RGBCCT".
Documentation and Comment Labels
wled00/bus_wrapper.h
Inline comments and section labels for ESP32/ESP8266 bus methods updated to reflect CCT channel naming for FW1906, WS2805, SM16825; file now includes a UTF-8 BOM on #pragma once.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main purpose of the changeset—renaming CW (Cold White) descriptions to CCT (Correlated Color Temperature) across LED type definitions in both digital and analog bus implementations.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@intermittech

Copy link
Copy Markdown
Contributor

Oh, I am 100% for that!

Any term other than RGBCCT or RGB+CCT is confusing in my opinion. WW is generally used for "Warm White" and CW is often used for "Cold White", that's fine. Things we're okay up until RGBW but then people starting calling it RGBWW or RGBCW sometimes, denoting the particular color temperature of that strip but there things went wrong, sometimes using RGBCW as referring to dual white also since the C and W is in there, very confusing. I've also seen it written as RGBWWCW, less confusing but still a bit meh in my opinion.

CCT is clear what it means, dual white color temperature
RGBCCT is also clear what it means, R+G+B with dual white

RGBW stays as is, R+G+B with a single white (whatever temperature)

I sometimes use the distinction of RGBCCT and RGB+CCT if the white is integrated into the same package, or external, but for the software side, that really doesn't matter, CCT and RGBCCT is the correct way to do it in my opinion.

Comment thread wled00/bus_manager.cpp Outdated

@softhack007 softhack007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for me 👍
Same as @intermittech says, I remember there were different namings around when RGB strips got white as an extra LED. CCT seems to be the term that "survived".

To be discussed: maybe we could always use the RGB+" naming?

  • RGB (no white)
  • RGB+W (single white - either cold or warm white)
  • RGB+CCT (both warm and cold white)
  • White (single white)
  • CCT (cold+warm)

Not sure what to do with "CCT + Amber" strips that have three white channels?

@intermittech

intermittech commented May 14, 2026

Copy link
Copy Markdown
Contributor

Oh that is a good one @softhack007, there is a SK6812 WWA which has Warm, Cold and Amber White, I'd say it's so much of an exception (and the only one of that sort as far as I am aware) that it shouldn't define the naming for the rest. So maybe we just keep it as an exception to the rule, I think that's fine.

It seems the PWM naming was done by another developer and that it's 5 channel mode is called RGB+CCT, maybe just clean it all up and make it the same and I'd personally choose for RGBCCT then.

@softhack007

Copy link
Copy Markdown
Member

It seems the PWM naming was done by another developer and that it's 5 channel mode is called RGB+CCT, maybe just clean it all up and make it the same and I'd personally choose for RGBCCT then

@DedeHai while we are at this, should we also change the "analogue" naming scheme?

@softhack007 softhack007 added this to the 16.1 milestone May 30, 2026
@DedeHai DedeHai merged commit ae4b2b3 into wled:main Jun 18, 2026
25 checks passed
@DedeHai DedeHai deleted the rename_CW_to_CCT branch June 18, 2026 10:44
@DedeHai

DedeHai commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

cherry picked into 16_x

DedeHai added a commit that referenced this pull request Jun 18, 2026
* rename CW LED descriptions to more commonly used CCT
* reorder, make naming more consistent
* unify LED type naming
* remove TYPE_WS2812_2CH_X3 as it is not implemented and same as FW1906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request direct IC configuration for WS2811 RGBCCT LED strip

3 participants