chore(doc): require 'path:' prefix for seedSdk - #1380
alekseifedotov wants to merge 2 commits into
Conversation
|
No concrete correctness or merge-blocking issues found in the PR changes. |
There was a problem hiding this comment.
Pull request overview
Updates onboarding guidance to ensure Nix reliably resolves the local Seek Thermal SDK input by requiring the path: prefix when overriding seekSdk.
Changes:
- Document using
path:PATH_FROM_STEP_3for--override-input seekSdkto avoid Nix resolving to a git repo root unexpectedly. - Update
.envrc.exampleto showpath:usage inVENDORED_SEEK_PATH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/src/first-time-setup.md | Clarifies the path: prefix requirement and explains the failure mode when the SDK path is inside a git repo. |
| .envrc.example | Updates the example SDK override variable to include the path: prefix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No concrete correctness, security, or regression issues found in the PR changes. The documented |
3705de9 to
751842e
Compare
|
No concrete correctness, security, or merge-blocking issues found in the documentation-only changes. |
If the seekSdk is inside of workdir and there is no 'path:' prefix, it will fail to find the sdk
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
751842e to
ef190fe
Compare
|
No concrete issues found. The documentation and |
If the seekSdk is inside of workdir and there is no 'path:' prefix, it will fail to find the sdk