Skip to content

fix: orb name on Android - #1384

Merged
alekseifedotov merged 6 commits into
mainfrom
aleksei/fix-orb-name-on-android
Sep 26, 2026
Merged

alekseifedotov merged 6 commits into
mainfrom
aleksei/fix-orb-name-on-android

Conversation

@alekseifedotov

@alekseifedotov alekseifedotov commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Add implementation for getting the orb name on Android. The name is derived from orb-id, there is 1:1 match between them.

for example orbid 666666 always has name appear-fabric-abandon and you can find orb id from the name without looking up any database.

NOTE: orb-ids for mini are 3 words, not 2 like for diamond and pearl, that will help us distinguish them at a glance.

@alekseifedotov
alekseifedotov requested a review from a team as a September 3, 2026 19:46
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
  • orb-info/Cargo.toml:18 — On Android, orb-name now imports crate::orb_id, but the orb-name feature does not enable orb-id. --no-default-features --features orb-name therefore fails to compile. Add "orb-id" to the orb-name feature dependencies.

@alekseifedotov alekseifedotov changed the title Aleksei/fix orb name on android fix: orb name on android Sep 3, 2026
@alekseifedotov alekseifedotov changed the title fix: orb name on android fix: orb name on Android Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
  • Blocking: orb-jobs-agent/src/handlers/orb_details.rs:16 now serializes OrbName directly, but this crate does not enable orb-info’s serde feature. Building orb-jobs-agent independently will fail because OrbName: Serialize is unsatisfied. Keep .to_string() or enable the feature.

  • Blocking (Android + serde): orb-info/src/orb_name_android.rs:115 calls String::deserialize without importing serde::Deserialize. This configuration will not compile; use <String as serde::Deserialize>::deserialize(deserializer) or import the trait.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
  • Blocking — orb-jobs-agent/src/handlers/orb_details.rs:16: OrbName is now serialized directly, but orb-jobs-agent does not enable orb-info’s serde feature. This causes standalone builds of orb-jobs-agent to fail because OrbName: Serialize is unavailable. Enable "serde" in its orb-info features or retain orb_name.to_string().

@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-id-on-android branch from 04f787b to d7befe4 Compare September 3, 2026 23:08
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from 80b4e30 to b183705 Compare September 3, 2026 23:09
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
  • Blocking – Android serde build fails: orb-info/src/orb_name_android.rs:115 calls String::deserialize without importing serde::Deserialize. This path is exercised because attest now enables orb-info/serde. Import the trait or use <String as serde::Deserialize>::deserialize(deserializer).

@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from b183705 to 2006386 Compare September 3, 2026 23:18
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-id-on-android branch 6 times, most recently from 14be670 to bf98856 Compare September 4, 2026 00:23
@alekseifedotov
alekseifedotov marked this pull request as draft September 4, 2026 00:23
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-id-on-android branch from bf98856 to b62d1d7 Compare September 4, 2026 18:05
@alekseifedotov alekseifedotov added the diffiulty:medium Hurt me plenty label Sep 4, 2026
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-id-on-android branch from b62d1d7 to 3c4a022 Compare September 9, 2026 00:29

@sfikastheo sfikastheo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope i think we should merge it

@pophilpo
pophilpo force-pushed the aleksei/fix-orb-id-on-android branch from 3c4a022 to d66ee49 Compare September 15, 2026 17:42
An error occurred while trying to automatically change base from aleksei/fix-orb-id-on-android to aleksei/refactor-use-test-orb-id September 15, 2026 18:43
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from 2006386 to d2cf4dd Compare September 25, 2026 23:04
@alekseifedotov
alekseifedotov changed the base branch from aleksei/fix-orb-id-on-android to main September 25, 2026 23:06
@alekseifedotov
alekseifedotov marked this pull request as ready for review September 25, 2026 23:06
@github-actions

Copy link
Copy Markdown
  • [P2] orb-name alone no longer compiles on Android — orb-info/src/orb_name_android.rs:1 imports crate::orb_id, but that module is gated behind the separate orb-id feature. orb-name only enables dep:hex, so an Android build with --no-default-features --features orb-name fails with unresolved imports. Make orb-name enable orb-id and add a check for this feature combination.

Build verification was unavailable because the Rust toolchain requires writes in this read-only environment.

@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from d2cf4dd to 9761baf Compare September 26, 2026 00:31
@github-actions

Copy link
Copy Markdown
  • [P2] Enable orb-id when enabling orb-name — orb-info/src/orb_name_android.rs:1 unconditionally imports crate::orb_id, but that module is gated behind the independent orb-id feature. Building for Android with --no-default-features --features orb-name now fails with an unresolved import. Add "orb-id" to the orb-name feature dependencies and check this feature combination.

Review was static; tests were not run in the read-only environment.

@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from 9761baf to 58b8f27 Compare September 26, 2026 00:49
@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from 58b8f27 to 12eaacb Compare September 26, 2026 00:49
@github-actions

Copy link
Copy Markdown
  • [P2] Android CI fails on a redundant import — orb-info/src/orb_name_android.rs:2: use bip39; triggers Clippy’s default single_component_path_imports lint. The Android CI runs cargo x android-clippy with -D warnings, making this a merge blocker. Remove the import; the existing bip39::... references work without it.

No other concrete correctness issues found. Build and tests were not run in the read-only environment.

@alekseifedotov
alekseifedotov force-pushed the aleksei/fix-orb-name-on-android branch from 12eaacb to 0bf5a1a Compare September 26, 2026 00:57
@github-actions

Copy link
Copy Markdown

No concrete merge-blocking issues found in the PR changes. The Android name encoding and parsing appear consistent, with tests covering round trips, invalid input, checksum failures, and serialization.

Tests were not run because the workspace is read-only.

@alekseifedotov
alekseifedotov merged commit dd0cafc into main Sep 26, 2026
25 checks passed
@alekseifedotov
alekseifedotov deleted the aleksei/fix-orb-name-on-android branch September 26, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffiulty:medium Hurt me plenty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants