You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
orb-info/Cargo.toml:18 — On Android, orb-name now imports crate::orb_id, but the orb-name feature does not enable orb-id. --no-default-features --features orb-name therefore fails to compile. Add "orb-id" to the orb-name feature dependencies.
alekseifedotov
changed the title
Aleksei/fix orb name on android
fix: orb name on android
Sep 3, 2026
Blocking:orb-jobs-agent/src/handlers/orb_details.rs:16 now serializes OrbName directly, but this crate does not enable orb-info’s serde feature. Building orb-jobs-agent independently will fail because OrbName: Serialize is unsatisfied. Keep .to_string() or enable the feature.
Blocking (Android + serde):orb-info/src/orb_name_android.rs:115 calls String::deserialize without importing serde::Deserialize. This configuration will not compile; use <String as serde::Deserialize>::deserialize(deserializer) or import the trait.
Blocking — orb-jobs-agent/src/handlers/orb_details.rs:16:OrbName is now serialized directly, but orb-jobs-agent does not enable orb-info’s serde feature. This causes standalone builds of orb-jobs-agent to fail because OrbName: Serialize is unavailable. Enable "serde" in its orb-info features or retain orb_name.to_string().
Blocking – Android serde build fails:orb-info/src/orb_name_android.rs:115 calls String::deserialize without importing serde::Deserialize. This path is exercised because attest now enables orb-info/serde. Import the trait or use <String as serde::Deserialize>::deserialize(deserializer).
An error occurred while trying to automatically change base from
aleksei/fix-orb-id-on-android to
aleksei/refactor-use-test-orb-idSeptember 15, 2026 18:43
[P2] orb-name alone no longer compiles on Android — orb-info/src/orb_name_android.rs:1 imports crate::orb_id, but that module is gated behind the separate orb-id feature. orb-name only enables dep:hex, so an Android build with --no-default-features --features orb-name fails with unresolved imports. Make orb-name enable orb-id and add a check for this feature combination.
Build verification was unavailable because the Rust toolchain requires writes in this read-only environment.
[P2] Enable orb-id when enabling orb-name — orb-info/src/orb_name_android.rs:1 unconditionally imports crate::orb_id, but that module is gated behind the independent orb-id feature. Building for Android with --no-default-features --features orb-name now fails with an unresolved import. Add "orb-id" to the orb-name feature dependencies and check this feature combination.
Review was static; tests were not run in the read-only environment.
[P2] Android CI fails on a redundant import — orb-info/src/orb_name_android.rs:2: use bip39; triggers Clippy’s default single_component_path_imports lint. The Android CI runs cargo x android-clippy with -D warnings, making this a merge blocker. Remove the import; the existing bip39::... references work without it.
No other concrete correctness issues found. Build and tests were not run in the read-only environment.
No concrete merge-blocking issues found in the PR changes. The Android name encoding and parsing appear consistent, with tests covering round trips, invalid input, checksum failures, and serialization.
Tests were not run because the workspace is read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation for getting the orb name on Android. The name is derived from orb-id, there is 1:1 match between them.
for example orbid
666666always has nameappear-fabric-abandonand you can find orb id from the name without looking up any database.NOTE: orb-ids for mini are 3 words, not 2 like for diamond and pearl, that will help us distinguish them at a glance.