Skip to content

feat: refactor tests - #1385

Open
alekseifedotov wants to merge 3 commits into
mainfrom
aleksei/refactor-use-test-orb-id
Open

feat: refactor tests#1385
alekseifedotov wants to merge 3 commits into
mainfrom
aleksei/refactor-use-test-orb-id

Conversation

@alekseifedotov

@alekseifedotov alekseifedotov commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

A bunch of small fixes:

  • add function test_orb_id() returing a pre-defined orb-id to be used only in tests.
  • use OrbId instead of &str for orb-id
  • fix a race in a zenorb test

@alekseifedotov
alekseifedotov requested a review from a team as a code owner September 4, 2026 00:00
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
  • Compile blocker: attest/src/remote_api.rs:771 now requires OrbId: Serialize, but attest/Cargo.toml does not enable orb-info’s serde feature. The same crate’s tests import test_orb_id at line 1140 without enabling the testing feature. Please enable both required features, with testing preferably as a dev-dependency feature.

  • Compile blocker: speed-test/src/lib.rs:87 changed the serialized field from &str to &OrbId, but speed-test/Cargo.toml does not enable orb-info/serde. Consequently, deriving Serialize for PackageRequest fails.

@alekseifedotov
alekseifedotov force-pushed the aleksei/refactor-use-test-orb-id branch from 69c4a05 to e75979f Compare September 4, 2026 00:12
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

No concrete correctness, security, race-condition, or regression issues found in the PR changes.

@alekseifedotov alekseifedotov changed the title feat: refactor tests: use test orb feat: refactor tests: use test_orb_id() in tests Sep 4, 2026
@alekseifedotov alekseifedotov changed the title feat: refactor tests: use test_orb_id() in tests feat: refactor tests Sep 4, 2026
@alekseifedotov
alekseifedotov force-pushed the aleksei/refactor-use-test-orb-id branch from e75979f to 81644d4 Compare September 4, 2026 00:17
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

No concrete correctness, security, race-condition, or merge-blocking issues found in the PR changes.

@alekseifedotov
alekseifedotov force-pushed the aleksei/refactor-use-test-orb-id branch from 81644d4 to 278e2ee Compare September 4, 2026 18:05
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

No concrete correctness, security, race-condition, or regression issues found in the PR changes.

@alekseifedotov alekseifedotov added the diffiulty:medium Hurt me plenty label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diffiulty:medium Hurt me plenty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant