Skip to content

feat: add temp stop mode - #1403

Merged
AlexKaravaev merged 1 commit into
mainfrom
alex/stop-ui-event
Sep 21, 2026
Merged

AlexKaravaev merged 1 commit into
mainfrom
alex/stop-ui-event

Conversation

@AlexKaravaev

@AlexKaravaev AlexKaravaev commented Sep 6, 2026 •

Copy link
Copy Markdown
Collaborator

Add a mode that disables any ui for predefined period of time

@AlexKaravaev
AlexKaravaev requested a review from a team as a code owner September 6, 2026 04:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-21T11:27:57.476627Z c0fbdf5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
  • [P2] Short sampling requests can expire without blanking any LEDs — ui/src/engine/diamond.rs:1114. The deadline starts when the event is handled, but black frames are only sent on the next 30 Hz rendering tick. A positive request shorter than ~33 ms can therefore expire before any black frame is sent; longer requests also lose part of their blackout interval. Start the duration when the blackout frame is emitted, and add coverage for requests arriving between ticks.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6716d971aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/src/engine/diamond.rs
Comment thread ui/src/engine/diamond.rs
@github-actions

Copy link
Copy Markdown
  • [P2] Short blackout requests can expire without switching off any LEDs — ui/src/engine/diamond.rs:1114. The deadline starts when the event is handled, but black frames are only sent on the next 30 FPS tick. A duration_ms: 10 request arriving with 20 ms until that tick expires without ever blanking the LEDs, compromising the ambient-light sample. Start the duration when blackout output begins, and add a regression test for requests shorter than one frame interval.

@AlexKaravaev
AlexKaravaev enabled auto-merge (squash) September 21, 2026 11:36
@AlexKaravaev
AlexKaravaev merged commit c9fffe4 into main Sep 21, 2026
26 of 27 checks passed
@AlexKaravaev
AlexKaravaev deleted the alex/stop-ui-event branch September 21, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants