[Misc] Check the pull requests targeting stable-18.4.x with Checkstyle and SonarQube - #446
Merged
Merged
Conversation
…e and SonarQube * Add the quality-pr.yml and quality-pr-sonar.yml stubs, as they are on master, so that a pull request targeting stable-18.4.x -- a backport especially -- gets the `Quality / Analyze` check. Both workflows only run on a branch that carries them: pull_request builds the pull request merged into its base, and pull_request_target runs the copy held by the base branch. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira URL
None,
[Misc]change.Changes
Description
.github/workflows/quality-pr.ymland.github/workflows/quality-pr-sonar.yml, copied frommaster, so that pull requests targetingstable-18.4.x(backports especially) get theQuality / Analyzecheck: a compile of the changed modules with Checkstyle, plus the SonarQube verdict on the lines the pull request writes.Clarifications
xwiki/.github/.github/workflows/quality-pr.yml@master, which has nothing specific tomaster: the JDK comes from the branch's ownxwiki.java.version, the Sonar settings from the branch's poms, and the diff base is the pull request's base branch.pull_requestbuilds the pull request merged into its base, andpull_request_targetruns the copy held by the base branch. That is why these files are added here and not backported from a PR.github-actions[bot]) still need a maintainer to click Approve and run before the check runs. That is a separate problem, handled inxwiki/.github.Screenshots & Video
N/A
Executed Tests
Quality / Analyzecheck is the first run of the workflow againststable-18.4.x.Expected merging strategy
🤖 Generated with Claude Code