fix(maple): handle broken poolCollaterals, add PoR divergence check#292
Merged
Conversation
- Stop querying poolCollaterals resolver which fails on unregistered native assets (PT_sUSDE/PT_USR). - Add Proof-of-Reserves vs syrupGlobals collateral divergence check (0.1% threshold). - Detect new collateral assets via collateralDisclosure when values are unavailable. - Route GraphQL skip alerts to dedicated errors channel. - Update ASSET_RISK_SCORES and README for currently disclosed collateral.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maple's
poolCollateralsGraphQL resolver currently fails on unregistered native assets (PT_sUSDE,PT_USR), causing a recurring warning. This PR stops fetching the broken field and replaces the lost monitoring with:proofOfReserves.totalCollateralValueagainstsyrupGlobals.collateralValueand alerts at ≥0.1% divergence.collateralDisclosure { asset }to alert on newly disclosed assets not inASSET_RISK_SCORES.Changes
protocols/maple/collateral.py:poolCollateralsfrom the GraphQL query; renamefetch_collateral_data()tofetch_pools_data().fetch_proof_of_reserves()andcheck_proof_of_reserves().fetch_collateral_disclosure()andcheck_unknown_collateral_assets().ASSET_RISK_SCORESwith newly disclosed assets.protocols/maple/README.md: