Skip to content

fix: ignore commented contract links - #12

Merged
zagrosi-code merged 2 commits into
mainfrom
fix/forge-comment-links
Sep 23, 2026
Merged

zagrosi-code merged 2 commits into
mainfrom
fix/forge-comment-links

Conversation

@zagrosi-code

@zagrosi-code zagrosi-code commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Links inside HTML comments were treated as required contracts, so an obsolete missing target could block context packets, implementation setup and progress recording.

Scan comments and code in source order while preserving visible links, backtick labels and multiline destinations. Honor escaped comment openers and keep inline spans from consuming fenced examples. Reuse existing fence helpers without adding dependencies. Refresh the plugin version for installation.

Addresses PR #11 review feedback.

Validation: baseline regressions reproduced; 931 local tests passed (one skipped), including 128 focused checks. Linux, macOS and Windows CI passed. Strict doctor and all nine release checks pass. Independent review found no remaining material issues.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T14:15:34.692688Z d67dfd7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d67dfd7614

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/forge/context_links.py
@zagrosi-code
zagrosi-code merged commit 204fcb4 into main Sep 23, 2026
4 checks passed
@zagrosi-code
zagrosi-code deleted the fix/forge-comment-links branch September 23, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant