[pull] master from scrapinghub:master - #101
Merged
Merged
Conversation
dateparser/timezones.py maps each timezone abbreviation to a single UTC offset. Unrelated zones often share the same letters, and because the table was scraped from Wikipedia, a few abbreviations ended up with a meaning no tz database zone has. "BST" resolved to +11, although the only zones named "BST" today are the UK ones, at +1 (#1321). Rather than patching that one value, compare the whole table against the tz database and fix every abbreviation it disagrees with: - BST: 39600 -> 3600 (British Summer Time) - HDT: -34200 -> -32400 (Hawaii-Aleutian Daylight Time, America/Adak) Abbreviations the tz database names with several offsets, such as CST, IST and PST, are left alone, because there is no single offset to prefer. Abbreviations no zone is named after any more, such as AHST and LMT, are kept so historical text still parses. The comparison lives in dateparser_scripts/tz_abbreviation_conflicts.py and uses pytz, already a dependency, whose bundled copy of the tz database gives the same answer on every platform; zoneinfo would depend on OS-provided data that Windows lacks without the tzdata package. Parsing is unchanged and still uses the static table. Fixes #1322 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )