fix(deps): clear the three reachable govulncheck findings - #120
Merged
Conversation
The scheduled scan has been failing on main since the clean break, on three advisories reachable through lego's dependency graph: GO-2026-6061 google.golang.org/grpc v1.77.0 -> v1.82.1 GO-2026-5506 go.opentelemetry.io/otel v1.38.0 -> v1.43.0 GO-2026-4945 github.com/go-jose/go-jose v4.1.3 -> v4.1.4 All three are indirect: grpc and otel arrive via lego's gcloud DNS provider, go-jose via lego's ACME core, and the reachable traces run through autocert's GetCertificate, the idle controller, and the provider registry's init. otel goes to v1.43.0 rather than the v1.41.0 the advisory names as its fix floor, because grpc v1.82.1 requires v1.43.0 and the two must move together. govulncheck now reports zero reachable vulnerabilities on both CI target platforms (linux/amd64 and linux/arm64). The residual unreachable findings in required modules are unchanged and are not what the workflow gates on. Closes #117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheduled
Securityworkflow has been failing onmainsince the clean break — #117, and again in today's run. Three advisories, all reachable:google.golang.org/grpcgo.opentelemetry.io/otelgithub.com/go-jose/go-jose/v4All three are indirect. grpc and otel arrive through lego's gcloud DNS provider; go-jose through lego's ACME core. The reachable traces run via
autocert.Manager.GetCertificate(router.go:602),IdleController.Close(idle_controller.go:178), and the provider registry'sinit(acme/providers/registry.go:8).go.mod/go.sumonly — no source changes.Closes #117
Note on the otel version
The advisory names v1.41.0 as the fix floor, but this goes to v1.43.0: grpc v1.82.1 requires it, and
go getrefuses the combination otherwise. The two have to move together.Test plan
go build ./...,go vet ./...— cleango test ./...— full suite greengovulncheck ./...on linux/amd64 —Your code is affected by 0 vulnerabilitiesgovulncheck ./...on linux/arm64 — same (both are CI scan targets)The residual "1 vulnerability in packages you import and 3 in modules you require, but your code doesn't appear to call these" is unchanged by this PR and is not what the workflow gates on —
ACCEPTEDis empty and the check counts only the reachable set.Deviations & judgment calls
ACCEPTEDentries added. The workflow supports suppressing advisories; I did not use it, since all three had real fixes available and suppression would have hidden reachable vulnerabilities rather than resolved them.