chore(deploy): deploy the docs with dash 4.0.7 - #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dash v4.0.7 is released (doctor passes a stale proxy the next deploy reboots automatically, #149; registry login fails fast on a blank credential, #148). Two changes so the docs site deploys with it:
docs/config/deploy.ymlgainsminimum_version: 4.0.7(the key was missing here — an older scaffold)..github/workflows/deploy-docs.ymlbumps its SHA pin of the docs-kit reusable workflow to zoolutions/docs-kit@833b23a (chore(deploy): require dash 4.0.7 across the docs deploy path docs-kit#79), which installsdash ~> 4.0.7.Test plan
Config-only change — the docs redeploy after merge is the proof.
https://claude.ai/code/session_01KsqvKPn1c1hWu6NSEQHy1W
Summary by cubic
Deploys the docs site with dash 4.0.7 so the docs no longer deploy with an older CLI that can't handle the 4.x proxy rename and in-place host migration.
zoolutions/docs-kitworkflow pin to the commit that installsdash ~> 4.0.7.minimum_version: 4.0.7key todocs/config/deploy.yml.Written for commit 25ddbd1. Summary will update on new commits.